ci: update to cibuildwheel 3.0 #345
Conversation
| test-extras = "test" | ||
| test-command = "pytest {project}/tests" | ||
| manylinux-x86_64-image = "manylinux2014" | ||
| manylinux-i686-image = "manylinux2014" |
There was a problem hiding this comment.
Do you need 32-bit linux? We've removed it from "auto", so you need to add "auto32" for it. I don't think numpy ships 32-bit linux wheels?
There was a problem hiding this comment.
We don't build them those wheels either. So this is fine.
There was a problem hiding this comment.
We can also now try building the musl linux variant FWIW
| @@ -90,11 +90,11 @@ strict_equality = true | |||
| ignore_missing_imports = true | |||
|
|
|||
| [tool.cibuildwheel] | |||
| skip = "pp*" | |||
| # Skip musllinux builds for the moment | |||
| skip = "*-musllinux_*" | |||
| test-extras = "test" | |||
| test-command = "pytest {project}/tests" | |||
| manylinux-x86_64-image = "manylinux2014" | |||
There was a problem hiding this comment.
Why are you pinning an old version here? We've moved to manylinux_2_28, and numpy 2.3 only ships 2_28 wheels. Why no numpy 2.3, by the way?
There was a problem hiding this comment.
There's a bug in awkward array that makes it incompatible with 2.3 for the time being. The fix is in progress.
There was a problem hiding this comment.
So long as python 3.9 is supported in manylinux_2_28 I'm fine to use the default. But let's do that in another PR since this is just a CI tool update.
There was a problem hiding this comment.
You can leave 3.9 and 3.10 as manylinux 2014 if you want, that's also an option with overrides.
There was a problem hiding this comment.
I don't think there's a very good reason to.
No description provided.